fix: addBasicStyle option set to false should prevent any basic styles#53
Open
lexoyo wants to merge 1 commit intoGrapesJS:masterfrom
Open
fix: addBasicStyle option set to false should prevent any basic styles#53lexoyo wants to merge 1 commit intoGrapesJS:masterfrom
lexoyo wants to merge 1 commit intoGrapesJS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @artf
It's been a long time i have a workaround in silex for this, hopefully you'll find the time to review it
When addBasicStyle is set to false, only the <style> tags in column blocks were removed
The inline style properties on text, link, image, video, and map blocks were always applied regardless of the setting
This fix makes addBasicStyle: false also omit inline styles from those blocks